Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tiny-go): fix generated code in type_flags function #911

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

rajatjindal
Copy link
Contributor

prior to this fix, wit content as follows

    /// Flags determining the method of how paths are resolved.
    flags path-flags {
        /// As long as the resolved path corresponds to a symbolic link, it is
        /// expanded.
        symlink-follow,
    }

is generated as

(notice the dash between SYMLINK-FOLLOW)

type WasiFilesystem0_2_0_TypesPathFlags uint64
const (
WasiFilesystem0_2_0_TypesPathFlags_SYMLINK-FOLLOW WasiFilesystem0_2_0_TypesPathFlags = 1 << iota
)

After the fix:

type WasiFilesystem0_2_0_TypesPathFlags uint64
const (
WasiFilesystem0_2_0_TypesPathFlags_SymlinkFollow WasiFilesystem0_2_0_TypesPathFlags = 1 << iota
)

@rajatjindal
Copy link
Contributor Author

requesting review from @Mossaka @alexcrichton

@alexcrichton
Copy link
Member

Thanks! Mind dropping a test case for this in tests/codegen/*.wit as well?

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
@rajatjindal
Copy link
Contributor Author

@alexcrichton alexcrichton added this pull request to the merge queue Mar 28, 2024
Merged via the queue into bytecodealliance:main with commit ed26dbf Mar 28, 2024
12 checks passed
mergify bot pushed a commit to andrzejressel/pulumi-wasm that referenced this pull request Apr 3, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [wit-bindgen](https://togithub.com/bytecodealliance/wit-bindgen) | workspace.dependencies | minor | `0.23.0` -> `0.24.0` |
| [wit-bindgen-rt](https://togithub.com/bytecodealliance/wit-bindgen) | workspace.dependencies | minor | `0.23.0` -> `0.24.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/wit-bindgen (wit-bindgen)</summary>

### [`v0.24.0`](https://togithub.com/bytecodealliance/wit-bindgen/releases/tag/v0.24.0)

[Compare Source](https://togithub.com/bytecodealliance/wit-bindgen/compare/v0.23.0...v0.24.0)

##### Go

-   Fixed a build error for generated type names for flags: [bytecodealliance/wit-bindgen#911
-   Fixed a build error for generated filed names that are Go keywords: [bytecodealliance/wit-bindgen#912
-   Add the ability to rename Go packages: [bytecodealliance/wit-bindgen#915

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants