Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color of your left video is (A, A, A,1.0), and the color of your right video is (R * A, G A, B * A,1.0).
The mix colors in shader are (R A, G *A, B *A,A).
So shader color is actually pre-multiplied.
And then use it in the VideoRenderer
GLES20.glBlendFunc(GLES20.GL_SRC_ALPHA,GLES20.GL_ONE_MINUS_SRC_ALPHA)
Merged (0,0,0,0)
In fact, the final color is (R A A, G AA, B * A *A, A * A).
This is wrong, blend two pre-multiplied colors that must be used
GLES20.glBlendFunc(GLES20. GL_ONE, GLES20.GL_ONE_MINUS_SRC_ALPHA).
if left video is (A, A, A,1.0), and right video is (R , G , B ,1.0),in shader must Multiplied A