cpu-stuck due to multiple registration of nf_hooks #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nf_register_hooks must be called only once upon nf_hook object, otherwise it would lead dead-loop and thus system hang. We are using register_pernet_subsys as unified soltuion for all network namespaces, but nf_register_net_hooks is only available kernels >= 4.3.0. nf_register_net_hooks is called per-net, while nf_register_hook is NOT. So we need limit the calling of nf_register_hooks, and the same to it's pair: nf_unregister_hooks. Signed-off-by: shenping.matt <shenping.matt@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nf_register_hooks must be called only once upon nf_hook object, otherwise it would lead dead-loop and thus system hang.
We are using register_pernet_subsys as unified soltuion for all network namespaces, but nf_register_net_hooks is only available kernels >= 4.3.0. nf_register_net_hooks is called per-net, while nf_register_hook is NOT. So we need limit the calling of nf_register_hooks, and the same to it's pair: nf_unregister_hooks.