This PR modifies some code formatting #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hk-lrzy
approved these changes
Nov 16, 2022
|
@hk-lrzy Some checks were not successful,please look ; |
garyli1019
reviewed
Nov 18, 2022
| @@ -61,7 +61,7 @@ public static Matcher listMatcher(String column) { | |||
| return LIST_VALUE_PATTERN.matcher(column); | |||
| } | |||
|
|
|||
| public static enum PathType { | |||
There was a problem hiding this comment.
@aozeyu why do we remove this static
There was a problem hiding this comment.
@garyli1019 hi, I think the properties of the enumeration java have already helped us turn it into static, there is no need to add static in front of the enumeration.
There was a problem hiding this comment.
Got it, thanks for the information!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
Some description about what this PR wants to do.
Approaches
Some description about how this PR achives the purpose.
Related Issues
e.g. Close #796
New Behavior (screenshots if needed)
N/A