-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BitSail][Connector] Migrate ftp legacy connector to V1 interface #211
Conversation
hi @BlockLiu ,it timed out when downloading maven dependency. How do i retry the failed CICD. |
@zeliu force push an empty commit or rewrite the last commit will retrigger the build. |
...ava/com/bytedance/bitsail/connector/ftp/source/reader/deserializer/ITextRowDeserializer.java
Outdated
Show resolved
Hide resolved
...java/com/bytedance/bitsail/connector/ftp/source/reader/deserializer/JsonRowDeserializer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeliu thanks for your contribution, left some comments
...t-csv/src/main/java/com/bytedance/bitsail/component/format/csv/CsvDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...ain/java/com/bytedance/bitsail/connector/ftp/source/reader/DeserializationSchemaFactory.java
Outdated
Show resolved
Hide resolved
bitsail-connectors/connector-ftp/src/test/resources/data/csv/upload2/test1.csv
Outdated
Show resolved
Hide resolved
...s/connector-ftp/src/main/java/com/bytedance/bitsail/connector/ftp/core/config/FtpConfig.java
Outdated
Show resolved
Hide resolved
...s/connector-ftp/src/main/java/com/bytedance/bitsail/connector/ftp/core/config/FtpConfig.java
Outdated
Show resolved
Hide resolved
.../com/bytedance/bitsail/connector/ftp/source/split/coordinator/FtpSourceSplitCoordinator.java
Outdated
Show resolved
Hide resolved
.../com/bytedance/bitsail/connector/ftp/source/split/coordinator/FtpSourceSplitCoordinator.java
Show resolved
Hide resolved
.../com/bytedance/bitsail/connector/ftp/source/split/coordinator/FtpSourceSplitCoordinator.java
Show resolved
Hide resolved
.../com/bytedance/bitsail/connector/ftp/source/split/coordinator/FtpSourceSplitCoordinator.java
Show resolved
Hide resolved
.../com/bytedance/bitsail/connector/ftp/source/split/coordinator/FtpSourceSplitCoordinator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! LGTM!
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
Migrate ftp legacy connector to V1 interface
Approaches
Migrate ftp legacy connector to V1 interface
Related Issues
#135
New Behavior (screenshots if needed)
N/A