Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail][Connector] Migrate ftp legacy connector to V1 interface #211

Merged
merged 16 commits into from
Dec 13, 2022

Conversation

zeliu
Copy link
Contributor

@zeliu zeliu commented Nov 30, 2022

Signed-off-by:

Pre-Checklist

Note: Please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests.

Purpose

Migrate ftp legacy connector to V1 interface

Approaches

Migrate ftp legacy connector to V1 interface

Related Issues

#135

New Behavior (screenshots if needed)

N/A

@zeliu zeliu closed this Nov 30, 2022
@zeliu zeliu reopened this Nov 30, 2022
@zeliu
Copy link
Contributor Author

zeliu commented Nov 30, 2022

hi @BlockLiu ,it timed out when downloading maven dependency. How do i retry the failed CICD.

@garyli1019
Copy link
Collaborator

@zeliu force push an empty commit or rewrite the last commit will retrigger the build.

Copy link
Collaborator

@garyli1019 garyli1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeliu thanks for your contribution, left some comments

Copy link
Collaborator

@garyli1019 garyli1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! LGTM!

@garyli1019 garyli1019 merged commit 0aa3b46 into bytedance:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants