Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail][Docs] Update License. #239

Merged
merged 9 commits into from
Dec 15, 2022
Merged

Conversation

BlockLiu
Copy link
Collaborator

Signed-off-by: Liu Peng

Pre-Checklist

Note: Please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests.

Purpose

Some description about what this PR wants to do.

Approaches

Change old ASF license to standard Apache 2.0 license.

Related Issues

Close #236

New Behavior (screenshots if needed)

N/A

@BlockLiu BlockLiu changed the title Update License. [BitSail][Docs] Update License. Dec 13, 2022
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlockLiu BlockLiu merged commit bd83d9d into bytedance:master Dec 15, 2022
@BlockLiu BlockLiu deleted the refactor-license branch December 15, 2022 10:40
@@ -186,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copyright 2022 Bytedance Ltd. and/or its affiliates.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlockLiu
This is the License header template that needs to be applied to the source code.
We are not supposed to add the copyright information here.
Could you review the change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just LICENSE file right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, see #342.
Thanks for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Please don't use ASF Customered License header
3 participants