Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail][Features] Support list and map in current FileMappingTypeInfoConverter #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyle-hawk
Copy link
Contributor

@kyle-hawk kyle-hawk commented Feb 1, 2023

Signed-off-by:

Pre-Checklist

Note: Please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests.

Purpose

Approaches

For complex types like list and Map, use BitSail type string as the bridge between engine type string and typeInfo, and convert engine type string like Map(String,Map(String,Int32)) into map<string,map<string ,int>> such BitSail type string, and then realize the conversion between BitSail type string and typeInfo through BitSailTypeParser
image

Related Issues

New Behavior (screenshots if needed)

N/A

target.type: map

- source.type: (
target.type: <
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we didn't need this part, we can consider it as default

target.type: <

- source.type: )
target.type: '>'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we didn't need this part, we can consider it as default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do this because I want to leave an entry for connector developers so that they can make the engine type string as close as possible to the type description of the engine itself. I think this has two advantages:

  1. It can constrain the field types configured by users ;
  2. Users have a clearer principle to know how to configure the engine type—consistent with the original type of the engine. Type configurations such as int32 and double64 will make users doubtful

@hk-lrzy look forwards ur further advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BitSail][Features] Support list and map in current FileMappingTypeInfoConverter.
3 participants