Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MaybeArmedBoxFuture API #170

Merged
merged 1 commit into from
May 24, 2023
Merged

Expose MaybeArmedBoxFuture API #170

merged 1 commit into from
May 24, 2023

Conversation

har23k
Copy link
Contributor

@har23k har23k commented May 23, 2023

  • Useful when porting Tokio specific poll based crates like H2 to monoio

@har23k
Expose MaybeArmedBoxFuture API
828e9ac 
- Useful when porting Tokio specific poll based crates like H2 to monoio
ethe
ethe approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@ethe ethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ihciah ihciah merged commit 73421a2 into bytedance:master May 24, 2023
4 checks passed
@har23k har23k deleted the box_future branch May 24, 2023 16:42
@har23k har23k mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihciah ihciah ihciah approved these changes

@ethe ethe ethe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@har23k @ihciah @ethe