Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parse number as raw #60

Closed
wants to merge 8 commits into from
Closed

feat: support parse number as raw #60

wants to merge 8 commits into from

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Apr 11, 2023

To maintain the lossless, support parse number as raw json instead of float or integer.

If you want parse numbers as raw number, can use doc.template Parse<kParseRawNumber>(json).

Proposal : #61

@codecov-commenter
Copy link

Codecov Report

Merging #60 (f7a2b98) into master (50514ec) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   95.88%   95.92%   +0.03%     
==========================================
  Files          21       21              
  Lines        2431     2427       -4     
==========================================
- Hits         2331     2328       -3     
+ Misses        100       99       -1     
Impacted Files Coverage Δ
include/sonic/dom/dynamicnode.h 96.08% <100.00%> (ø)
include/sonic/dom/genericnode.h 99.63% <100.00%> (ø)
include/sonic/dom/handler.h 100.00% <100.00%> (+0.95%) ⬆️
include/sonic/dom/parser.h 94.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuq19 liuq19 marked this pull request as ready for review April 12, 2023 05:50
@xiegx94
Copy link
Collaborator

xiegx94 commented Apr 12, 2023

DNode(const DNode<SourceAllocator>& rhs, Allocator& alloc, bool copyString = false)
operator==(const DNode<SourceAllocator>& rhs)
destroy()
Above functions need process when type is kRawNumber. Also kRaw

@liuq19
Copy link
Collaborator Author

liuq19 commented Apr 19, 2023

kRawNumber suppprt construct,copy and compare

@liuq19 liuq19 closed this by deleting the head repository Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants