Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic does not support go1.20 #355

Closed
iwanlebron opened this issue Feb 2, 2023 · 7 comments
Closed

sonic does not support go1.20 #355

iwanlebron opened this issue Feb 2, 2023 · 7 comments

Comments

@iwanlebron
Copy link

github.com/bytedance/sonic/internal/loader

../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:27:22: undefined: _ModuleData
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:30:27: undefined: _ModuleData
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:41:6: undefined: _Func
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:42:12: undefined: _ModuleData
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:53:16: undefined: _ModuleData
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:79:26: undefined: _ModuleData
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata_invalid.go:23:6: panic("Unsupported Go version. Supported versions are: 1.15, 1.16, 1.17, 1.18, 1.19") (no value) used as value
../../../go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/loader.go:47:50: too many arguments in call to registerFunction
have (string, uintptr, uintptr, int, int, uintptr, uintptr, uintptr)
want (string, uintptr, int, int, uintptr)

@ii64
Copy link
Contributor

ii64 commented Feb 2, 2023

There's on going implementation to support go120:
#354 (merge feat/go120 into main)
https://github.com/bytedance/sonic/tree/feat/go120

@AsterDY
Copy link
Collaborator

AsterDY commented Feb 2, 2023

WIP

@kataras
Copy link

kataras commented Feb 2, 2023

I can confirm that too for https://github.com/kataras/iris

# github.com/bytedance/sonic/internal/loader
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:27:22: undefined: _ModuleData
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:30:27: undefined: _ModuleData
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:41:6: undefined: _Func
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:42:12: undefined: _ModuleData
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:53:16: undefined: _ModuleData
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata.go:79:26: undefined: _ModuleData
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/funcdata_invalid.go:23:6: panic("Unsupported Go version. Supported versions are: 1.15, 1.16, 1.17, 1.18, 1.19") (no value) used as value
/go/pkg/mod/github.com/bytedance/sonic@v1.7.0/internal/loader/loader.go:47:50: too many arguments in call to registerFunction
	have (string, uintptr, uintptr, int, int, uintptr, uintptr, uintptr)
	want (string, uintptr, int, int, uintptr)
The command '/bin/sh -c go install -ldflags="-s -w"' returned a non-zero code: 1

@redghc
Copy link

redghc commented Feb 3, 2023

At the moment I recommend you use a specific version of go:
https://go.dev/doc/manage-install

$ go install golang.org/dl/go1.19.5@latest
$ go1.19.5 download

$ cd /your/project/path
$ go1.19.5 run .

@hiqsociety
Copy link

waiting for this too.
wonder when the eta of merge is?

@iwanlebron
Copy link
Author

does the new version have a schedule?

@AsterDY
Copy link
Collaborator

AsterDY commented Feb 8, 2023

#354 resloved

@AsterDY AsterDY closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants