-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NVIDIA Video Codec Preset for Windows #1020
Conversation
That sample java code based on nvidia official nvidia video codec sample c++ code. |
Thanks! I'm wondering though, could we use the header files from https://github.com/FFmpeg/nv-codec-headers? |
@saudet i think header files is fine. but missing nvcuvid link file. |
ok, let's test compile with "replace official sdk header files to that repository header files" and "use official link(dll) file". and i will let you know result. |
Yeah, that's not going to work. We'll need to do the same as TensorRT here I'm afraid: |
okey, you mean "write 'download video sdk and unzip' code to each platform github action", right? |
Yes, it's only Linux and Windows, but it's still annoying. |
i will upload each platform nvcodec SDK files to google driver and modify github action script. btw, why you didn't check downloaded file hash check? isn't dangerous? (if i upload modulated dll to google driver and i link it...? it is terrible) |
AFAIK, there is only 1 zip for all platforms, but it needs to be installed for each, yes.
Sure, we can add hash checks, that would be a good thing, contributions are welcome! Please open another PR to do that though.
|
I added git actions and fix small sample problem. |
Please add a workflow for GitHub Actions here to get this tested: |
Sorry, i added |
Ah... something happen.. should i have to change nvcodec dependency javacpp version 1.5.5-snap to 1.5.6-snap? |
oops.. i forgot linux support code in pom.xml... so i commited.... xD but i don't know why windows build failure |
i will close this pr and check again. |
oh.. i found reason.. i think we need merge nvcodec action file to bytedeco/javacpp-presets@action branche |
I pushed |
Fixed #1026 |
Feel free to include the fix for TensorRT in this PR. Thanks! |
Nice! |
Hey, I'd like to fix a few nits before merging this. Can you give me push access to this branch? |
Invited! |
Ok, this looks good to merge! Let me know if this looks to you. |
@saudet that goes without saying! nice! |
Fixed #1008
Fixed #1026