-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrappers for FLandmark library #9
Conversation
Hi, thanks for the PR! Though, would it be possible to adjust the flandmark presets to do stuff locally in the As for the FlyCapture, have you considered replacing the "hacks" with the following?
I could do it myself after a merge, but since I've proposed that previously, I'm just wondering what the rationale is, thanks. |
I adjusted code to do FLandmark stuff locally in FlyCapture is on its own branch so I did modification there (see #6). |
We'll probably need to adjust that for Linux as well, but that's alright. Apart of that, I'm not entirely sure myself yet how to handle dependencies across modules. One thing for sure, instead of copying files around, we can set compiler flags in the
But I'm not there yet with Tesseract, so in any case, I'll get back to you on that if you don't try it before. |
I added a simple example of using flandmark wrapper to javacv-examples on |
All commits are now squashed into a single one. Only flandmark changes are in, FlyCaptyre 2 commits are excluded. Code was tested using sample code in |
Ok, sounds good! Sorry for the delay in replying. I was finishing up Leptonica and Tesseract. I think the way I've done things for those two should be adopted for flandmark as well because it makes it closest to how JavaCPP would see it if it were one project as usual and without copying files, thus less likely to cause surprises, I think. Could you take the time to check this out? Thanks! |
Wrappers for FLandmark library. Assumes that FLandmark binaries are pre-build as described in
flandmark/README.md
.Due to some branching mishap early on, this PR has also initial support for FlyCapture 2, C API only. C++ API will be in separate PR, once completed. FlyCapture 2 (C API) wrappers are tested and work fine.
I have some samples for both wrappers (FLandmak and FlyCapture 2 C API), planning to add to
javacv-examples
project.