Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch panic when negating the identity element #35

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Conversation

bytemare
Copy link
Owner

No description provided.

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #35 (127d3a7) into main (b866f41) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   81.47%   81.53%   +0.05%     
==========================================
  Files          16       16              
  Lines         934      953      +19     
==========================================
+ Hits          761      777      +16     
- Misses        112      113       +1     
- Partials       61       63       +2     
Impacted Files Coverage Δ
internal/nist/group.go 86.11% <0.00%> (ø)
internal/edwards25519/map.go 84.26% <66.66%> (-1.85%) ⬇️
internal/nist/element.go 70.58% <100.00%> (+0.89%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bytemare bytemare merged commit 409260c into main Mar 18, 2023
@bytemare bytemare deleted the patch-element-negate branch March 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant