Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scalar.SetUInt64, remove Scalar.SetBigInt, add Hex() and DecodeHe… #57

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

bytemare
Copy link
Owner

…x(), add tests

…x(), add tests

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 95.78947% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (b866f41) to head (fc74736).
Report is 16 commits behind head on main.

Files Patch % Lines
internal/edwards25519/scalar.go 86.66% 1 Missing and 1 partial ⚠️
internal/ristretto/scalar.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   81.47%   90.82%   +9.34%     
==========================================
  Files          16       19       +3     
  Lines         934     1439     +505     
==========================================
+ Hits          761     1307     +546     
+ Misses        112       76      -36     
+ Partials       61       56       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bytemare bytemare merged commit cd6020a into main Jun 10, 2024
11 of 12 checks passed
@bytemare bytemare deleted the set-int32 branch June 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant