fix: Support passing data along with hook

Closes #16
bytesonus · May 7, 2020 · 79f85d5 · 79f85d5
1 parent 10c2d58
commit 79f85d5
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 7 deletions.
diff --git a/src/juno-node.ts b/src/juno-node.ts
@@ -110,9 +110,9 @@ export default class JunoModule {
 		);
 	}
 
-	public async triggerHook(hook: string) {
+	public async triggerHook(hook: string, data: any = {}) {
 		return this.sendRequest(
-			this.protocol.triggerHook(hook)
+			this.protocol.triggerHook(hook, data)
 		);
 	}
 
@@ -219,7 +219,7 @@ export default class JunoModule {
 				}
 			} else if (this.hookListeners[request.hook]) {
 				for (const listener of this.hookListeners[request.hook]) {
-					listener();
+					listener(request.data || {});
 				}
 			}
 			return true;

diff --git a/src/models/messages.ts b/src/models/messages.ts
@@ -28,6 +28,9 @@ export interface RegisterHookRequest extends BaseMessage {
 
 export interface TriggerHookRequest extends BaseMessage {
 	hook: string;
+	data: {
+		[type: string]: any
+	};
 }
 
 export interface RegisterModuleResponse extends BaseMessage {
@@ -43,7 +46,6 @@ export interface ListenHookResponse extends BaseMessage {
 
 export interface TriggerHookResponse extends BaseMessage {
 	hook: string;
-	data?: any;
 }
 
 export interface DeclareFunctionResponse extends BaseMessage {

diff --git a/src/protocol/base-protocol.ts b/src/protocol/base-protocol.ts
@@ -42,11 +42,12 @@ export abstract class BaseProtocol {
 		};
 	}
 
-	public triggerHook(hook: string): TriggerHookRequest {
+	public triggerHook(hook: string, data: any): TriggerHookRequest {
 		return {
 			requestId: this.generateRequestId(),
 			type: RequestTypes.TriggerHook,
-			hook
+			hook,
+			data
 		};
 	}
 

diff --git a/test/juno-node.test.ts b/test/juno-node.test.ts
@@ -106,12 +106,29 @@ makeConnectionTests('Test if requests constructed correctly', function () {
 		});
 	});
 
-	it('triggerHook', function () {
+	it('triggerHook with no args', function () {
 		this.test.module.triggerHook('test_hook');
 		const message = this.test.getLatestSent();
 		expect(message).excluding('requestId').to.deep.equal({
 			type: 7,
 			hook: 'test_hook',
+			data: {},
+		});
+	});
+
+	it('triggerHook with args', function () {
+		this.test.module.triggerHook('test_hook', {
+			a:1,
+			b:2,
+		});
+		const message = this.test.getLatestSent();
+		expect(message).excluding('requestId').to.deep.equal({
+			type: 7,
+			hook: 'test_hook',
+			data: {
+				a: 1,
+				b: 2,
+			}
 		});
 	});
 });