Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing data along with hooks not supported #16

Closed
thebongy opened this issue May 6, 2020 · 0 comments
Closed

Passing data along with hooks not supported #16

thebongy opened this issue May 6, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@thebongy
Copy link
Contributor

thebongy commented May 6, 2020

As per
https://github.com/bytesonus/juno/blob/develop/docs/COMMUNICATION-PROTOCOL.md#trigger-hook
data can also be passed along with a juno hook.
Currently, the library doesn't support passing data along with triggerHook or passing along data to hook listeners. Need to add support for this and add tests too,

@thebongy thebongy added the bug Something isn't working label May 6, 2020
thebongy added a commit that referenced this issue May 7, 2020
* feat #4: TCP sockets support added

* feat #4: Error handling for socket path

* fix #7: Import destructuring and minor fixes

* fix #7: fs renamed to fsPromises

* Update github repo link

* fix: Don't fail build if just version check fails if not publishing release

* 0.1.0 beta test release (#11)

* fix: Correct downloaded atrifact name

* Test staging release

* Update build.yml

* fix: Bump version in package.json on staging

* fix: bump version

* fix: rename tar file

* fix: Rename tar only if doesn't exist

* fix

* Removed unnecessarry await

* fix: Support passing data along with hook
Closes #16

Co-authored-by: Saurav M. H <sauravhiremath@gmail.com>
Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant