Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #293 #294

Merged
merged 2 commits into from Aug 7, 2017
Merged

Fixes #293 #294

merged 2 commits into from Aug 7, 2017

Conversation

blakemorgan
Copy link
Contributor

Summary of Changes

Fixes Issue #293

What did you change? If this is a bug fix, how did you fix it?
I added a left margin to the mobile menu button. The issue was only noticeable if the title was a certain length. Otherwise it would wrap in a way that the missing margin was unnoticeable.
If this fixes styling, please include before and after screenshots!
img_0105

Browser Testing

I have tested these changes in:

Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.

Desktop Browsers

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Microsoft Internet Explorer 11
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

We support the last two versions of Chrome, Firefox, Safari, and Edge,
plus Internet Explorer 11.

Copy link
Contributor

@kevin-larry-bauer kevin-larry-bauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-larry-bauer kevin-larry-bauer merged commit dd7e9e4 into master Aug 7, 2017
@blakemorgan blakemorgan deleted the title-menu-button branch August 14, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants