Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CSS to include both margin and padding for footer columns #441

Merged
merged 2 commits into from Dec 12, 2018

Conversation

kevin-larry-bauer
Copy link
Contributor

Summary of Changes

Updated The CSS to include both the margin and padding for footer columns.

Fixes Issue #(Add issue number here)
Fixes Issue #435

If this fixes styling, please include before and after screenshots!

Before:
image

After:
image

Browser Testing

I have tested these changes in:

Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.

Desktop Browsers

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

We support the last two versions of Chrome, Firefox, Safari, and Edge.

Copy link
Contributor

@Gi60s Gi60s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Gi60s Gi60s merged commit 7131f35 into master Dec 12, 2018
@Gi60s Gi60s deleted the footer-column-fix branch December 12, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants