Skip to content

Commit

Permalink
Revert PR #659 (#754)
Browse files Browse the repository at this point in the history
As described in #753 the change
merged with #659 is ill-advised and
leads to breakage in applications using c-ares on OpenBSD.

See also nodejs/node#52439
  • Loading branch information
VlkrS committed May 8, 2024
1 parent abff625 commit daf00b9
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/lib/ares__socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,12 +253,6 @@ ares_status_t ares__open_connection(ares_channel_t *channel,
struct server_connection *conn;
ares__llist_node_t *node;
int type = is_tcp ? SOCK_STREAM : SOCK_DGRAM;
#ifdef __OpenBSD__
if ((is_tcp && server->tcp_port == 53) ||
(!is_tcp && server->udp_port == 53)) {
type |= SOCK_DNS;
}
#endif

switch (server->addr.family) {
case AF_INET:
Expand Down

0 comments on commit daf00b9

Please sign in to comment.