Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ares_nameser.h as a public interface #415

Closed
felixonmars opened this issue Aug 17, 2021 · 1 comment
Closed

Provide ares_nameser.h as a public interface #415

felixonmars opened this issue Aug 17, 2021 · 1 comment

Comments

@felixonmars
Copy link
Contributor

felixonmars commented Aug 17, 2021 •
edited

Node.js has a wrapper for c-ares that depends on this header. Is it possible to provide the file as a public interface and install by default?

It is used here: https://github.com/nodejs/node/blob/master/src/cares_wrap.h

See also discussions here: nodejs/node#39739 (comment)
@bradh352
Copy link
Member

sure, I don't have a problem with that, it would be a fairly minor change in c-ares. The main thing is we'd need to add a couple of new defines to ares_build.h for the HAVE_ARPA_NAMESER.H and friends, but namespace them with CARES_ to prevent clashes.

felixonmars added a commit to felixonmars/c-ares that referenced this issue Aug 17, 2021
@felixonmars
Provide ares_nameser.h as a public interface
b9845b8 
Implements c-ares#415.
@felixonmars felixonmars mentioned this issue Aug 17, 2021
Merged
sergepetrenko pushed a commit to tarantool/c-ares that referenced this issue Jul 29, 2022
@felixonmars @sergepetrenko
Provide ares_nameser.h as a public interface (c-ares#417)
3df0204 
NodeJS needs ares_nameser.h as a pubic header.

Fixes: c-ares#415
Fix By: Felix Yan (@felixonmars)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felixonmars @bradh352