Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ares_nameser.h as a public interface #417

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Provide ares_nameser.h as a public interface #417

merged 3 commits into from
Aug 17, 2021

Conversation

felixonmars
Copy link
Contributor

Implements #415.

@bradh352
Copy link
Member

  • move src/lib/ares_nameser.h -> include/ares_nameser.h
  • in include/CMakeLists.txt, need to add the ares_nameser.h to the header list
  • in configure.ac (or one of the .m4 files) need to set CARES_HAVE_ARPA_NAMESER_H and CARES_HAVE_ARPA_NAMESER_COMPAT_H
  • in include/ares_build.h.in need to add the placeholders for CARES_HAVE_ARPA_NAMESER_H and CARES_HAVE_ARPA_NAMESER_COMPAT_H
  • Need to include ares_build.h at the top of ares_nameser.h in case it is included without first including ares.h or similar.

@felixonmars
Copy link
Contributor Author

I have some trouble trying to understand the autotools part here. Do I need to write a dnl from scratch? Seems that I cannot test it too:

$ autoreconf -ifv
<snip>
aclocal: error: too many loops
aclocal: Please contact <bug-automake@gnu.org>.
 at /usr/share/automake-1.16/Automake/Channels.pm line 655.
        Automake::Channels::msg("automake", "", "too many loops") called at /usr/share/automake-1.16/Automake/ChannelDefs.pm line 226
        Automake::ChannelDefs::prog_error("too many loops") called at /usr/bin/aclocal line 1187
autoreconf: error: aclocal failed with exit status: 255

@bradh352
Copy link
Member

There is some issue going on with newer automake versions. Can you tell me what automake version you have? We have 2 issues on that #409 and #416. It would be useful if you could tell me what OS and version of the various tools you are running like those 2 tickets (actually, it would be useful to put the output in the ticket #416) to help isolate.

@felixonmars
Copy link
Contributor Author

It seems to be still broken - the generated ares_build.h still has

/* #undef CARES_HAVE_ARPA_NAMESER_H */
/* #undef CARES_HAVE_ARPA_NAMESER_COMPAT_H */

While the files are present.

@felixonmars
Copy link
Contributor Author

Okay, I should have done it right this time.

@bradh352 bradh352 mentioned this pull request Aug 17, 2021
Closed
@bradh352 bradh352 merged commit 7712fcd into c-ares:main Aug 17, 2021
@felixonmars felixonmars deleted the provide-ares_nameser.h branch August 17, 2021 17:33
@felixonmars felixonmars mentioned this pull request Aug 17, 2021
Closed
@Shikugawa Shikugawa mentioned this pull request Dec 9, 2021
Closed
sergepetrenko pushed a commit to tarantool/c-ares that referenced this pull request Jul 29, 2022
@felixonmars @sergepetrenko
Provide ares_nameser.h as a public interface (c-ares#417)
3df0204 
NodeJS needs ares_nameser.h as a pubic header.

Fixes: c-ares#415
Fix By: Felix Yan (@felixonmars)
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Nov 19, 2023
@jirutka
main/nodejs: remove obsolete patch fix-build-with-system-c-ares
a08daa5 
It's not needed anymore: c-ares/c-ares#417
bell-sw pushed a commit to bell-sw/alpaquita-aports that referenced this pull request Nov 23, 2023
@jirutka @akodanev
universe/nodejs: remove obsolete patch fix-build-with-system-c-ares
2be6a81 
[ commit a08daa58c1faa7ec69bb1aaf302f5e5570fe6ac8 ]

It's not needed anymore: c-ares/c-ares#417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixonmars @bradh352