Documentation says ares_options.udp_port is in network byte order

[aaron-michaux]

The documentation says:

ARES_OPT_UDP_PORT unsigned short udp_port;
The port to use for queries over UDP, in network byte order. The default value is 53 (in network byte order), the standard name service port.

Yet, the code says:

  // NOTE: c-ares is assuming `options->udp_port` is in host byte order!
  if ((optmask & ARES_OPT_UDP_PORT) && channel->udp_port == -1)
    channel->udp_port = htons(options->udp_port);

[bradh352]

I haven't looked into this, but did you confirm via testing the docs are wrong, or did you just happen to glance at the code?

The reason I ask is there are quite a few usages of htons and ntohs in the c-ares code involving ports, so it could be swapping twice which would mean the docs could be right.

[aaron-michaux]

Hi,

I tested the code, I read the code, and I read the docs. I'm pretty sure that the docs are wrong.

[bradh352]

fixed in a306ed4