windows: only look for ancient compilers #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop the use of a versioned output directory; just use .\msvc
bradh352
approved these changes
Sep 11, 2017
There was a problem hiding this comment.
Looks good to me, needing to list every version of MSVC always seemed like an odd choice.
Of course, I'd also approve a request to completely kill the MSVC build system and standardize on CMake for Windows ... but that's just me, I doubt there'd be wide support for that.
bagder
approved these changes
Sep 11, 2017
dimbleby
pushed a commit
to dimbleby/c-ares
that referenced
this pull request
Sep 11, 2017
Also drop the use of a versioned output directory; just use .\msvc
DronRathore
pushed a commit
to DronRathore/c-ares
that referenced
this pull request
Mar 11, 2020
Also drop the use of a versioned output directory; just use .\msvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop the use of a versioned output directory; just use
.\msvc