Fix building with latest autotools #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax_code_coverage.m4 needs an update and Makefile.am needs to be updated accordingly. Resolves the second failure in c-ares#416.
|
Ah, yes, it does appear the current |
felixonmars
added a commit
to felixonmars/c-ares
that referenced
this pull request
Aug 17, 2021
This was mostly copied from fenrus75/powertop#82 which was found from https://bugzilla.redhat.com/show_bug.cgi?id=1835638 I have no idea about this, but it indeed fixes the first `error: too many loops` error with automake 1.16.4 here. Hopefully fixes c-ares#416 completely, with c-ares#418 merged too.
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
ax_code_coverage.m4 dropped the @CODE_COVERAGE_RULES@ macro, so we need to switch to the latest recommendation from the m4 file. This requires updates to Makefile.am. Fix By: Felix Yan (@felixonmars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the second build error in #416 comes from
@CODE_COVERAGE_RULES@being left out at the file:ax_code_coverage.m4 needs an update and Makefile.am needs to be updated
accordingly. Resolves the second failure in #416.