Fix resetting display attributes on VT100 output #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it helps, I've made the same changes in a project of mine and works for me. |
|
Patch working for me too. I found this after I filed #93 for it. Thanks! |
c-bata
reviewed
Sep 11, 2018
| @@ -236,7 +236,7 @@ func (w *VT100Writer) SetColor(fg, bg Color, bold bool) { | |||
| if bold { | |||
| w.SetDisplayAttributes(fg, bg, DisplayBold) | |||
| } else { | |||
| w.SetDisplayAttributes(fg, bg, DisplayDefaultFont) | |||
| w.SetDisplayAttributes(fg, bg, DisplayDefaultFont, DisplayReset) | |||
There was a problem hiding this comment.
it seems to be equivalent to following:
w.SetDisplayAttributes(fg, bg, DisplayReset)
There was a problem hiding this comment.
That was another thing I tried that seemed to work but I didn't want to take out the DisplayDefaultFont in case it did something I wasn't aware of.
|
Merge this changes into master after removing |
|
Merged this in #104. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using go-prompt on urxvt on Arch Linux and I'm running into an issue where the bold attribute isn't being reset correctly after its first use. I don't know a lot about ANSI/VT100 but I wasn't able to find the '10' attribute that was currently being used, so I added the '0' attribute in addition to it. This fixed the bold not being reset on my terminal.
I haven't had a chance to test on Windows, Mac or the Gnome Terminal yet.