Add fuzzy match filter #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bata
reviewed
Oct 20, 2018
| @@ -109,3 +138,27 @@ func TestFilter(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestFuzzy(t *testing.T) { | |||
There was a problem hiding this comment.
TestFuzzyMatch is better to avoid conflict
c-bata
reviewed
Oct 20, 2018
| } | ||
|
|
||
| // FilterContains checks whether the completion.Text contains sub. | ||
| func FilterContains(completions []Suggest, sub string, ignoreCase bool) []Suggest { | ||
| func filterCommon(completions []Suggest, sub string, ignoreCase bool, test func(string, string) bool) []Suggest { |
There was a problem hiding this comment.
I think function is better than test, because filter function in python3 also uses function as the argument name.
https://docs.python.org/3.6/library/functions.html#filter
|
Suggested algorithm is quite simple. So it may replace with another algorithm in the future (refs #105) but I wanna merge this because it's better than nothing. |
|
I will merge this branch into master after fixing the name of variable and function that I commented. |
Merged
|
Merged into master branch. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completion filter is similar to fuzzy-finder search tools, which match as long as all search characters are present and in order. I find it a very effective method for rapidly searching.
I also factored out some repeated code that would otherwise appear in four functions. If you don't like that I can undo that part.