Implement CCImmutArray.sub, but creates a copy #159

ghost · 2017-11-20T16:15:25Z

No description provided.

c-cube · 2017-11-20T16:29:11Z

src/data/CCImmutArray.mli

@@ -36,6 +36,11 @@ val get : 'a t -> int -> 'a
 val set : 'a t -> int -> 'a -> 'a t
 (** Copy the array and modify its copy *)

+val sub : 'a t -> int -> int -> 'a t
+(** [sub a start len] returns a fresh array of length len, containing the elements number start to start + len - 1 of array a.
+    Raises [Invalid_argument "Array.sub"] if start and len do not designate a valid subarray of a; that is, if start < 0, or len < 0, or start + len > Array.length a. *)


the comment has too long lines (80~100 chars max is more readable)

please add @since NEXT_RELEASE to the end of the comment :-)

c-cube · 2017-11-20T20:46:04Z

Thanks! :)

Implement CCImmutArray.sub, but creates a copy

c49458d

c-cube reviewed Nov 20, 2017

View reviewed changes

Improve CCImmutArray.sub comments and versioning

a28dd39

c-cube merged commit 170d766 into c-cube:master Nov 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement CCImmutArray.sub, but creates a copy #159

Implement CCImmutArray.sub, but creates a copy #159

ghost commented Nov 20, 2017

c-cube Nov 20, 2017

c-cube commented Nov 20, 2017

Implement CCImmutArray.sub, but creates a copy #159

Implement CCImmutArray.sub, but creates a copy #159

Conversation

ghost commented Nov 20, 2017

c-cube Nov 20, 2017

Choose a reason for hiding this comment

c-cube commented Nov 20, 2017