BF: convert revision to str for call

[matthew-brett]

Avoid error converting str / bytes in subprocess.call

Without this change, on Windows and Python 3.5, I get this from ghp-import _build/html:

(py35) C:\repos\la-eeg-uci [master]> ghp-import.exe ._build\html
Traceback (most recent call last):
File "C:\tmp\py35\Scripts\ghp-import-script.py", line 9, in
load_entry_point('ghp-import==0.4.2', 'console_scripts', 'ghp-import')()
File "c:\repos\ghp-import\ghp_import.py", line 194, in main
if not try_rebase(opts.remote, opts.branch):
File "c:\repos\ghp-import\ghp_import.py", line 78, in try_rebase
if sp.call(cmd) != 0:
File "C:\Python35\lib\subprocess.py", line 560, in call
with Popen(_popenargs, *_kwargs) as p:
File "C:\Python35\lib\subprocess.py", line 950, in init
restore_signals, start_new_session)
File "C:\Python35\lib\subprocess.py", line 1194, in _execute_child
args = list2cmdline(args)
File "C:\Python35\lib\subprocess.py", line 754, in list2cmdline
needquote = (" " in arg) or ("\t" in arg) or not arg
TypeError: a bytes-like object is required, not 'str'

[waylan]

Any reason why you didn't just call dec(rev.strip()) with the dec function defined earlier? That works for me. AFAICT L77 should just be:

cmd = ['git', 'update-ref', 'refs/heads/%s' % branch, dec(rev.strip())]

[matthew-brett]

I think I'm right in saying that rev should always be a commit hash, so ascii or utf-8 decoding (via dec) should give the same result. I guess the only advantage of ascii is that it will give an error when the result is other than a hash.

[waylan]

True, but dec also does a type check and avoids a call to decode is it is not needed, possibly avoiding an error in some situations. Interestingly, the proposed fix in #42 also does the type check, but doesn't decode to ASCII. Seems like my proposed fix or #42 with ASCII would be a better fix.

[waylan]

This appears to be a duplicate of #42.