Fix metadata extractors #72

c-w · 2017-02-18T23:14:59Z

Add more data for metadata querying tests
Fix test setup

This PR resolves #70.

The unit tests related to "subject" metadata were set up incorrectly (invalid N-Triples formatting of the test data). This was not caught before because there was no test data exercising this code path.

The simple predicate extractor needs a contains method to do its job, so might as well document this via an abstract method that subclasses need to implement.

The unit tests related to "language" metadata were set up incorrectly (invalid N-Triples formatting of the test data). This was not caught before because there was no test data exercising this code path.

Fixes #70

coveralls · 2017-02-18T23:22:49Z

Coverage increased (+0.5%) to 94.521% when pulling 634eaa9 on fix-metadata-extractors into bd139bb on master.

This localizes all the code for every extractor into just one place which makes it easier to grasp all the things that the extractor does. For example, with this structure, it's obvious that the language extractor needs to bind the RFC 4646 type to string.

coveralls · 2017-02-18T23:39:01Z

Coverage increased (+0.5%) to 94.545% when pulling c8d4101 on fix-metadata-extractors into bd139bb on master.

c-w added 7 commits February 18, 2017 14:00

Add missing facts to tests

960df87

Remove need for listing all the rdf test facts

ace379d

Fix subject metadata tests

a1a5bcc

The unit tests related to "subject" metadata were set up incorrectly (invalid N-Triples formatting of the test data). This was not caught before because there was no test data exercising this code path.

Add some tests for rights extractor

a64a294

Fix PyCharm warning

23cc633

The simple predicate extractor needs a contains method to do its job, so might as well document this via an abstract method that subclasses need to implement.

Fix language metadata tests

93a2471

The unit tests related to "language" metadata were set up incorrectly (invalid N-Triples formatting of the test data). This was not caught before because there was no test data exercising this code path.

Add datatype to language metadata query

634eaa9

Fixes #70

c-w merged commit 042ae21 into master Feb 18, 2017

c-w deleted the fix-metadata-extractors branch February 18, 2017 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix metadata extractors #72

Fix metadata extractors #72

c-w commented Feb 18, 2017 •

edited

Loading

coveralls commented Feb 18, 2017 •

edited

Loading

coveralls commented Feb 18, 2017 •

edited

Loading

Fix metadata extractors #72

Fix metadata extractors #72

Conversation

c-w commented Feb 18, 2017 • edited Loading

coveralls commented Feb 18, 2017 • edited Loading

coveralls commented Feb 18, 2017 • edited Loading

c-w commented Feb 18, 2017 •

edited

Loading

coveralls commented Feb 18, 2017 •

edited

Loading

coveralls commented Feb 18, 2017 •

edited

Loading