Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent phantom metadata from crashing queries #75

Merged
merged 3 commits into from Feb 19, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Owner

commented Feb 19, 2017

This is a partial fix for the issue reported by @ikarth on #57.

c-w added some commits Feb 19, 2017

Allow for zero-valued etextno
There is a book with a zero as its etextno, so tests should be able to
reflect this.
Prevent phantom books from crashing queries
This is a partial fix for #57

@c-w c-w force-pushed the phantom-metadata-querying branch from d1b8e7a to a8e0c6a Feb 19, 2017

@coveralls

This comment has been minimized.

Copy link

commented Feb 19, 2017

Coverage Status

Coverage increased (+0.06%) to 94.607% when pulling a8e0c6a on phantom-metadata-querying into 33500f2 on master.

@coveralls

This comment has been minimized.

Copy link

commented Feb 19, 2017

Coverage Status

Coverage increased (+0.06%) to 94.607% when pulling a8e0c6a on phantom-metadata-querying into 33500f2 on master.

@coveralls

This comment has been minimized.

Copy link

commented Feb 19, 2017

Coverage Status

Coverage increased (+0.06%) to 94.607% when pulling a8e0c6a on phantom-metadata-querying into 33500f2 on master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Feb 19, 2017

Coverage Status

Coverage increased (+0.06%) to 94.607% when pulling a8e0c6a on phantom-metadata-querying into 33500f2 on master.

@coveralls

This comment has been minimized.

Copy link

commented Feb 19, 2017

Coverage Status

Coverage increased (+0.06%) to 94.607% when pulling a8e0c6a on phantom-metadata-querying into 33500f2 on master.

@c-w c-w merged commit d2df5ca into master Feb 19, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 94.607%
Details

@c-w c-w deleted the phantom-metadata-querying branch Feb 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.