Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added certificate parsing of ADExplorer snapshots, based on Certipy. #10

Merged
merged 1 commit into from
May 18, 2023

Conversation

PTVB
Copy link
Contributor

@PTVB PTVB commented Apr 6, 2022

Added certificate parsing from AD Snapshots, based on Certipy.

@c3c
Copy link
Owner

c3c commented Apr 6, 2022

This looks massive and awesome. Will review, test and merge in the next few days.

@OscarAkaElvis
Copy link

any update on this to be merged?

@helloyw
Copy link

helloyw commented May 16, 2023

Added certificate parsing from AD Snapshots, based on Certipy.
I installed the latest ceripy4.4 and still encountered this issue
ModuleNotFoundError: No module named 'certipy.constants'
image

@c3c c3c merged commit 1b5d351 into c3c:main May 18, 2023
@c3c
Copy link
Owner

c3c commented May 18, 2023

Added certificate parsing from AD Snapshots, based on Certipy.
I installed the latest ceripy4.4 and still encountered this issue
ModuleNotFoundError: No module named 'certipy.constants'
image

should be fixed in new commit :)
thanks for making this, apologies for taking so long

@helloyw
Copy link

helloyw commented May 19, 2023

添加了基于Certipy 的AD 快照中的证书解析。
我安装了最新的ceripy4.4,仍然遇到这个问题
ModuleNotFoundError: No module named 'certipy.constants'
图像

应该在新的提交中修复 :) 感谢你做这个,抱歉花了这么长时间
I have a new issue. After resolving the issue of missing dependency packages, I successfully found 37 certificate templates using ADExplorerSnapshot.py. When I imported the generated JSON file into BloodHound 4.2.0-ly4k and used Find all Certificate Templates, I couldn't find any information.
image

@c3c
Copy link
Owner

c3c commented May 19, 2023

Based on the output, you're working from a different branch than current main. I don't think that will resolve the problem though: current output format predates ly4k's version, that'll need to be implemented. I've created #17 to track this.

@helloyw
Copy link

helloyw commented May 19, 2023

根据输出,您正在与当前主分支不同的分支工作。我不认为这会解决问题:当前输出格式早于 ly4k 的版本,需要实施。我创建了#17来跟踪这个。

Great, looking forward to you solving this problem

@c3c
Copy link
Owner

c3c commented May 20, 2023

Should be implemented with latest commits.
Make sure to re-run pip as dependency versions have changed.

@helloyw
Copy link

helloyw commented May 22, 2023

I tested the latest warehouse and found an error running, AttributeError: 'ADExplorerSnapshot' object has no attribute 'numCAS' Did you mean: 'numCAs'?, You need to globally replace numCAS with numCAs to successfully run,I hope you can modify this issue again
image

@c3c
Copy link
Owner

c3c commented May 22, 2023

Ah forgot to stage that line for the main branch. 38e5100

@helloyw
Copy link

helloyw commented May 22, 2023

啊忘了为主要分支准备那条线。38e5100

You did a great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants