Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart.api ($$.api) to 'onunselected' callback #1147

Merged
merged 1 commit into from
Jun 6, 2015
Merged

Add chart.api ($$.api) to 'onunselected' callback #1147

merged 1 commit into from
Jun 6, 2015

Conversation

lbortoli
Copy link
Contributor

@lbortoli lbortoli commented May 6, 2015

It should behave as the 'onselected' callback.

It should behave as the 'onselected' callback.
masayuki0812 added a commit that referenced this pull request Jun 6, 2015
Add chart.api ($$.api) to 'onunselected' callback
@masayuki0812 masayuki0812 merged commit 429f2b4 into c3js:master Jun 6, 2015
@masayuki0812
Copy link
Member

You're right. Thanks!

@lbortoli
Copy link
Contributor Author

lbortoli commented Jun 9, 2015

Actually, I think it would be better to pass 'this' as a parameter for ALL the callbacks, instead of passing 'this.api', since we may have to use other components such as 'color' function for example...
Would you add that change in all the callbacks C3 provides? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants