New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix step-before and step-after with dedicated test (#2340) #2385

Merged
merged 2 commits into from Jun 8, 2018

Conversation

Projects
None yet
4 participants
@tanganellilore
Copy link
Contributor

tanganellilore commented Jun 6, 2018

Hi all

I request approval for this pull request for resolve the #2340 bug int he step chart with restore the "step-before" and "step-after" in the stop type graph.

I created a basic test for check if the graph works fine.
All test for my point of view are correctly ( I modify marginally the code of the graph).

For more usefull test I create two jsfiddle test
d3: v4.13.0 - https://jsfiddle.net/xjy7r25w/
d3: v5.4.0 - https://jsfiddle.net/p0qe247m/

Please accept this pull request.

Thanks
Lorenzo

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #2385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2385   +/-   ##
=======================================
  Coverage   77.23%   77.23%           
=======================================
  Files          51       51           
  Lines        4138     4138           
=======================================
  Hits         3196     3196           
  Misses        942      942
Impacted Files Coverage Δ
src/shape.js 78.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aced10d...2e6cd7e. Read the comment docs.

@tanganellilore

This comment has been minimized.

Copy link
Contributor Author

tanganellilore commented Jun 7, 2018

Hi @kt3k, @panthony and @masayuki0812,

can you approve this minimal change?
Thanks

@kt3k

This comment has been minimized.

Copy link
Member

kt3k commented Jun 8, 2018

@tanganellilore
Thanks for the contribution! Sorry for the delayed response...

The change seems good and I confirmed 'step-after' and 'step-before' work for line.step.type 👍

The source code seems including tab indentation. Can you replace these with 4-space indent? (If you use editorconfig compliant editor, it automatically formats them correctly.

@tanganellilore

This comment has been minimized.

Copy link
Contributor Author

tanganellilore commented Jun 8, 2018

Hi @kt3k ,

sorry for my mistake, I fix it!
I hadn't install editorconfig in my Visual Studio Code.

Now all is ok!

Thanks
Lorenzo

@kt3k

kt3k approved these changes Jun 8, 2018

Copy link
Member

kt3k left a comment

Thanks for the quick update! LGTM 👍

@kt3k kt3k merged commit b71853e into c3js:master Jun 8, 2018

2 checks passed

ci/circleci: test Your tests passed on CircleCI!
Details
codecov/project 77.23% remains the same compared to aced10d
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment