Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed chart height determination issue number 2467 (#2541)" #2580

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@kt3k
Copy link
Member

kt3k commented Mar 4, 2019

This reverts commit 89ef108.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #2580 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2580      +/-   ##
==========================================
+ Coverage   80.53%   80.54%   +<.01%     
==========================================
  Files          54       54              
  Lines        4280     4282       +2     
==========================================
+ Hits         3447     3449       +2     
  Misses        833      833
Impacted Files Coverage Δ
src/core.js 91.72% <100%> (+0.01%) ⬆️
src/size.js 93.5% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afcb3f...277ea4f. Read the comment docs.

@kt3k kt3k merged commit a6d10d3 into master Mar 4, 2019

3 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
circleci/htdocs preview build succes!
Details

@kt3k kt3k deleted the feature/revert-2541 branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.