Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use prettier, switch to 2 indent, no-semi #2766

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 1, 2020

This PR introduce prettier formatter and switches from 4 space indent to 2 space indent, and also switches from semicolon style to no-semicolon style.

(After this change I will remove jshint and introduces eslint instead.)

closes #2763

@kt3k kt3k requested a review from masayuki0812 March 1, 2020 05:13
@codecov-io
Copy link

codecov-io commented Mar 1, 2020

Codecov Report

Merging #2766 into master will decrease coverage by 0.88%.
The diff coverage is 49.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   82.91%   82.03%   -0.89%     
==========================================
  Files          60       60              
  Lines        4793     5159     +366     
==========================================
+ Hits         3974     4232     +258     
- Misses        819      927     +108
Impacted Files Coverage Δ
src/arc.js 76.14% <ø> (+1.06%) ⬆️
src/util.js 98.52% <ø> (+0.02%) ⬆️
src/zoom.js 70% <ø> (-0.13%) ⬇️
src/stanford.js 93.5% <ø> (+0.08%) ⬆️
src/grid.js 74.34% <ø> (-0.47%) ⬇️
src/colorscale.js 82.05% <ø> (ø) ⬆️
src/config.js 95.83% <ø> (ø) ⬆️
src/tooltip.js 81.45% <ø> (-0.67%) ⬇️
src/data.load.js 60.37% <ø> (-3.63%) ⬇️
src/subchart.js 84.76% <ø> (-2.74%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6749eb6...6a10d56. Read the comment docs.

@kt3k
Copy link
Member Author

kt3k commented Mar 2, 2020

@masayuki0812 Please take a look if you have time.

@kt3k
Copy link
Member Author

kt3k commented Mar 3, 2020

@masayuki0812 I believe this is a sensible change and this style conforms better to the modern trends of javascript ecosystem. Please let me know if you have a different opinion.

@kt3k kt3k merged commit 42df07b into master Mar 3, 2020
@kt3k kt3k deleted the feature/prettier branch March 3, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to 2 indent, use prettier for formatting.
2 participants