Put throw outside of try/catch

c4dt · Mar 12, 2024 · e80a2d9 · e80a2d9
1 parent f8d78b8
commit e80a2d9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 34 deletions.
diff --git a/web/frontend/src/components/utils/usePostCall.tsx b/web/frontend/src/components/utils/usePostCall.tsx
@@ -17,7 +17,9 @@ const usePostCall = (setError) => {
     try {
       const result = await response.json();
       if (result.Token) {
-        pollTransaction(checkTransaction, result.Token, 1000, 30).then(
+        // 600s is the time to shuffle 10'000 votes. This should be enough for
+        // everybody.
+        pollTransaction(checkTransaction, result.Token, 1000, 600).then(
           () => {
             setIsPosting((prev) => !prev);
           },

diff --git a/web/frontend/src/pages/form/components/FomrStatusLoading.tsx b/web/frontend/src/pages/form/components/FomrStatusLoading.tsx
diff --git a/web/frontend/src/pages/form/components/utils/TransactionPoll.ts b/web/frontend/src/pages/form/components/utils/TransactionPoll.ts
@@ -7,39 +7,40 @@ const pollTransaction = (
   let attempts = 0;
 
   const request = {
-    method: 'GET',
-    headers: { 'Content-Type': 'application/json' },
+    method: "GET",
+    headers: { "Content-Type": "application/json" }
   };
 
   const executePoll = async (resolve, reject): Promise<any> => {
+    let response, result;
     try {
       attempts += 1;
-      const response = await fetch(endpoint(data), request);
-      const result = await response.json();
-
-      if (!response.ok) {
-        throw new Error(JSON.stringify(result));
-      }
+      response = await fetch(endpoint(data), request);
+      result = await response.json();
+    } catch (e) {
+      return reject(e);
+    }
 
-      data = result.Token;
+    if (!response.ok) {
+      throw new Error(JSON.stringify(result));
+    }
 
-      if (result.Status === 1) {
-        return resolve(result);
-      }
+    data = result.Token;
 
-      if (result.Status === 2) {
-        throw new Error('Transaction Rejected');
-      }
+    if (result.Status === 1) {
+      return resolve(result);
+    }
 
-      // Add a timeout
-      if (attempts === maxAttempts) {
-        throw new Error('Timeout');
-      }
+    if (result.Status === 2) {
+      throw new Error("Transaction Rejected");
+    }
 
-      setTimeout(executePoll, interval, resolve, reject);
-    } catch (e) {
-      return reject(e);
+    // Add a timeout
+    if (attempts === maxAttempts) {
+      throw new Error("Timeout");
     }
+
+    setTimeout(executePoll, interval, resolve, reject);
   };
 
   return new Promise(executePoll);