Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-voter user should not see the ballot #117

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Non-voter user should not see the ballot #117

merged 2 commits into from
Feb 15, 2024

Conversation

PascalinDe
Copy link
Member

An authenticated but non-voter user should not see the ballot displayed when ending up at /ballot/show/$FORMID. Instead a page is shown informing the user that they are not allowed to vote in the election.

@PascalinDe PascalinDe self-assigned this Feb 15, 2024
Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix linter errors

@PascalinDe
Copy link
Member Author

  • Fix linter errors

this linting drives me crazy - I always run it before pushing but I somehow seem to be always missing something 😭

@ineiti
Copy link
Member

ineiti commented Feb 15, 2024

  • Fix linter errors

this linting drives me crazy - I always run it before pushing but I somehow seem to be always missing something 😭

We can add a .pre-commit-config.yaml, then you can define a pre-commit hook, so it always runs the linter. But I have more trouble with the pre-commit package than it solves...

Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on main and see if the go test passes?

@PascalinDe
Copy link
Member Author

Can you rebase on main and see if the go test passes?

all green 🥳

@PascalinDe PascalinDe merged commit 1a32df8 into main Feb 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants