Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply epfl styles #122

Closed
wants to merge 4 commits into from
Closed

apply epfl styles #122

wants to merge 4 commits into from

Conversation

lanterno
Copy link
Member

  • Use EPFL logo next to D-voting logo
  • Use EPFL recommended font "Arial"

I'm currently looking into adding suiss' int font.

@lanterno lanterno marked this pull request as ready for review February 22, 2024 11:44
@lanterno lanterno requested a review from ineiti February 22, 2024 11:44
@lanterno
Copy link
Member Author

We're still missing breadcrumb that Lindo mentioned, so I'll take a look on that in a following PR.

@PascalinDe
Copy link
Member

We're still missing breadcrumb that Lindo mentioned, so I'll take a look on that in a following PR.

please add it to this PR as it is part of the ticket

also, please add the missing test

Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please

  • add the missing test for the logo
  • check where the logo should redirect to (homepage or EPFL homepage)
  • add the breadcrumbs

@PascalinDe PascalinDe closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants