This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Archive update #119
Closed
Archive update #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
archive_update
branch
7 times, most recently
from
6dbd0c4
to
78b18de
Compare
PascalinDe
reviewed
Aug 24, 2023
| @@ -10,7 +10,8 @@ on: | |||
| jobs: | |||
| build: | |||
| name: Lint, build and test | |||
| runs-on: ubuntu-18.04 | |||
| runs-on: ubuntu-22.04 | |||
| if: false | |||
There was a problem hiding this comment.
why not remove this if it is never run?
PascalinDe
reviewed
Aug 24, 2023
| # with: | ||
| # context: backend | ||
| # push: true | ||
| # tags: c4dt/service-stainless-backend:latest |
There was a problem hiding this comment.
please remove the commented lines
PascalinDe
reviewed
Aug 24, 2023
docker-compose.yml
Outdated
| volumes: | ||
| - ./backend/build/conode-1:/config | ||
| # volumes: | ||
| # - ./backend/build/conode-1:/config |
There was a problem hiding this comment.
please remove the commented lines
PascalinDe
reviewed
Aug 24, 2023
docker-compose.yml
Outdated
| ports: | ||
| - "8080:8080" | ||
| # volumes: | ||
| # - ./webapp/src/assets:/webapp/assets |
There was a problem hiding this comment.
please remove the commented lines
|
Sorry, that was not supposed to be reviewed yet. I'm still in the middle of getting this one to work. And it's a mess! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the images on github.