Use default cURL timeouts by default to prevent accidental functional test failures on Travis CI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test failures on Travis CI Some tests on Travis CI fail because of connection timeout when connectin to pear.php.net: 1. https://travis-ci.org/phpbrew/phpbrew/jobs/285966800 2. https://travis-ci.org/phpbrew/phpbrew/jobs/287167227 3. https://travis-ci.org/phpbrew/phpbrew/jobs/290106834 It may help if the wrapper uses default cURL timouts by default: 1. https://curl.haxx.se/libcurl/c/CURLOPT_CONNECTTIMEOUT.html 2. https://curl.haxx.se/libcurl/c/CURLOPT_TIMEOUT.html
|
Awesome! Thanks! |
morozov
added a commit
to phpbrew/phpbrew
that referenced
this pull request
Oct 21, 2017
kevinnio
pushed a commit
to kevinnio/phpbrew
that referenced
this pull request
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests on Travis CI fail because of connection timeout when connection to pear.php.net:
It may help if the wrapper uses default cURL timouts by default: