Fix memory leaks

This changes a bunch of ivars to __weak's, to avoid reference loops.
Furthermore, in PBGitHistoryController, we need to call [webView close],
otherwise some memory will never be freed?

PBChangedFile.h

@@ -18,7 +18,7 @@ typedef enum {
 @interface PBChangedFile : NSObject {
 	NSString *path;
 	BOOL cached;
-	PBGitRepository *repository;
+	__weak PBGitRepository *repository;
 	PBChangedFileStatus status;
 }
 

PBGitHistoryController.h

@@ -16,6 +16,7 @@
 	IBOutlet NSTreeController* treeController;
 	IBOutlet NSOutlineView* fileBrowser;
 	IBOutlet NSTableView* commitList;	
+	IBOutlet id webView;
 	int selectedTab;
 
 	PBGitTree* gitTree;

PBGitHistoryController.m

@@ -179,4 +179,10 @@ - (BOOL) hasNonlinearPath
 {
 	return [commitController filterPredicate] || [[commitController sortDescriptors] count] > 0;
 }
+
+- (void) removeView
+{
+	[webView close];
+	[super removeView];
+}
 @end

PBGitHistoryView.xib

@@ -8,7 +8,7 @@
 		<string key="IBDocument.HIToolboxVersion">352.00</string>
 		<object class="NSMutableArray" key="IBDocument.EditedObjectIDs">
 			<bool key="EncodedWithXMLCoder">YES</bool>
-			<integer value="3"/>
+			<integer value="20"/>
 		</object>
 		<object class="NSArray" key="IBDocument.PluginDependencies">
 			<bool key="EncodedWithXMLCoder">YES</bool>
@@ -1328,6 +1328,14 @@
 					</object>
 					<int key="connectionID">111</int>
 				</object>
+				<object class="IBConnectionRecord">
+					<object class="IBOutletConnection" key="connection">
+						<string key="label">webView</string>
+						<reference key="source" ref="1001"/>
+						<reference key="destination" ref="676796335"/>
+					</object>
+					<int key="connectionID">112</int>
+				</object>
 			</object>
 			<object class="IBMutableOrderedSet" key="objectRecords">
 				<object class="NSArray" key="orderedObjects">
@@ -1830,7 +1838,7 @@
 						</object>
 					</object>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
-					<string>{{328, 233}, {852, 432}}</string>
+					<string>{{423, 120}, {852, 432}}</string>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
 					<string>com.apple.InterfaceBuilder.CocoaPlugin</string>
@@ -1860,7 +1868,7 @@
 				</object>
 			</object>
 			<nil key="sourceID"/>
-			<int key="maxID">111</int>
+			<int key="maxID">112</int>
 		</object>
 		<object class="IBClassDescriber" key="IBDocument.Classes">
 			<object class="NSMutableArray" key="referencedPartialClassDescriptions">
@@ -1920,13 +1928,15 @@
 							<string>commitList</string>
 							<string>fileBrowser</string>
 							<string>treeController</string>
+							<string>webView</string>
 						</object>
 						<object class="NSMutableArray" key="dict.values">
 							<bool key="EncodedWithXMLCoder">YES</bool>
 							<string>NSArrayController</string>
 							<string>NSTableView</string>
 							<string>NSOutlineView</string>
 							<string>NSTreeController</string>
+							<string>id</string>
 						</object>
 					</object>
 					<object class="IBClassDescriptionSource" key="sourceIdentifier">

PBGitWindowController.m

@@ -51,7 +51,7 @@ - (void)changeViewController:(NSInteger)whichViewTag
 	self.searchController = nil;
 	[self unbind:@"searchController"];
 	if ([viewController view] != nil)
-		[[viewController view] removeFromSuperview];	// remove the current view
+		[(PBViewController *)viewController removeView];
 
 	switch (whichViewTag)
 	{

PBViewController.h

@@ -11,12 +11,12 @@
 #import "PBGitWindowController.h"
 
 @interface PBViewController : NSViewController {
-	PBGitRepository *repository;
-	PBGitWindowController *superController;
+	__weak PBGitRepository *repository;
+	__weak PBGitWindowController *superController;
 }
 
-@property (readonly) PBGitRepository *repository;
+@property (readonly) __weak PBGitRepository *repository;
 
 - (id)initWithRepository:(PBGitRepository *)theRepository superController:(PBGitWindowController *)controller;
-
+- (void) removeView;
 @end

PBViewController.m

@@ -25,4 +25,8 @@ - (id)initWithRepository:(PBGitRepository *)theRepository superController:(PBGit
 	return self;
 }
 
+- (void) removeView
+{
+	[[self view] removeFromSuperview];	// remove the current view
+}
 @end