Added a new property to turn on/off GSVA features #2823
Conversation
| @@ -26,11 +27,15 @@ const styles = styles_any as { | |||
| @observer | |||
| export default class MolecularProfileSelector extends QueryStoreComponent<{}, {}> | |||
| { | |||
| private get showGSVA() { | |||
There was a problem hiding this comment.
We should only interface with configuration via AppConfig. So this would be AppConfig.serverConfig.skin_show_gsva.
I've tested it out and manipulating this via frontendConfig window global (as you do above in test) should still work.
There was a problem hiding this comment.
@alisman Thanks. I have updated the PR. So when should we use getBrowserWindow()?
There was a problem hiding this comment.
ideally never! it's a global and should be avoided. it's in the code base as a convenience to avoid having to pass, say, the routing store into the view layers. but really it's not a good practice. if you for some reason you find yourself needing to use it, let me know.
ngocnn1104
force-pushed
the
config_show_gsva
branch
from
a4a18e0
to
4b31be6
Compare
|
@alisman what still needs to be done to get this one merged? |
alisman
force-pushed
the
config_show_gsva
branch
from
4b31be6
to
e152e4a
Compare
Signed-off-by: Ngoc Nguyen <nguyennhungoc1104@gmail.com>
alisman
force-pushed
the
config_show_gsva
branch
from
e152e4a
to
c3e0f8d
Compare
Implemented cBioPortal/cbioportal#6749
Changes:
skin_show_gsvato frontendConfig with default value =false;src/config/serverConfigDefaults.tsand changeskin_show_gsva: false,toskin_show_gsva: true,;skin_show_gsvain frontendConfig totrue.