Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gnomad link url #2840

Merged
merged 1 commit into from Nov 19, 2019
Merged

fix gnomad link url #2840

merged 1 commit into from Nov 19, 2019

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Nov 5, 2019 •
edited

generate gnomad url by vcf

fix: cBioPortal/cbioportal#6770

@leexgh leexgh force-pushed the fix-gnomad-link branch 2 times, most recently from 09b488a to 44cceb7 Compare November 6, 2019 17:18
@onursumer
Copy link
Member

@leexgh @inodb We should apply these changes to react-mutation-mapper as well. Ideally, we should directly import the component from react-mutation-mapper to avoid duplicate code management. I will apply these changes to react-mutation-mapper and open a PR to address this issue after we merge #2706

onursumer
onursumer approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onursumer added a commit to onursumer/react-mutation-mapper that referenced this pull request Nov 6, 2019
@onursumer
fixed gnomad url (see cBioPortal/cbioportal-frontend#2840)
65b6c66
@onursumer onursumer mentioned this pull request Nov 6, 2019
Merged
@alisman alisman merged commit 8d13933 into cBioPortal:master Nov 19, 2019
@inodb inodb added the bug label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman approved these changes

@inodb inodb inodb approved these changes

@onursumer onursumer onursumer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@leexgh @onursumer @alisman @inodb