Create feedback form for trials #2869
Conversation
victoria34
force-pushed
the
google-form
branch
from
747f1cf
to
1a82259
Compare
| <span className={styles.statusBackground}>{trial.status}</span> | ||
| </a> | ||
| <span className={styles.feedback}> | ||
| <button className={"btn btn-default btn-sm btn-xs " + styles.feedbackButton} onClick={() => this.showTrialFeedback=true}>Feedback</button> |
There was a problem hiding this comment.
You could use a Button component from react-bootstrap
There was a problem hiding this comment.
Changed to Button component
| <div className={styles.statusButton}> | ||
| <a target="_blank" href={"https://www.mskcc.org/cancer-care/clinical-trials/" + trial.protocolNo}><span className={styles.statusBackground}>{trial.status}</span></a> | ||
| <div className={styles.statusContainer}> | ||
| <a target="_blank" href={"https://www.mskcc.org/cancer-care/clinical-trials/" + trial.protocolNo}> |
There was a problem hiding this comment.
Why not just use Button from react-bootstrap, and variant="link"
There was a problem hiding this comment.
Some css styles cannot apply for the Button component. Also, this is a link not a button. I don't want to mix them together.
| @@ -306,6 +327,13 @@ export default class TrialMatchTable extends React.Component<ITrialMatchProps> { | |||
| render() { | |||
| return ( | |||
| <div> | |||
| <p style={{marginBottom: '0'}}>Curated genomic and clinical criteria from open clinical trials at Memorial Sloan Kettering. Please <a href="mailto:team@oncokb.org">contact us</a> or submit <a onClick={() => this.showGeneralFeedback=true}>feedback form</a> if you have any questions.</p> | |||
There was a problem hiding this comment.
I'm surprised that changing showGeneralFeedback on the click event would actually work in mobx observable. @alisman what's the situation that a @autobind has to be attached?
There was a problem hiding this comment.
this will work. if you pass it a function directly (not an anonymous callback) then it has to be bound with autobind. Using an anonymous callback is discouraged b/c it causes virtual dom to be differed each time. But in this case, it's totally negligible and not worth changing. So, rule of thumb is, if something is going to be rendered a lot and occurs many times in DOM, then use a bound handler. If not, do the above.
victoria34
force-pushed
the
google-form
branch
4 times, most recently
from
6e3b0c5
to
96e4996
Compare
Fix oncokb/oncokb#1816