Frontend should consume postData written to JSP #2933
Conversation
There was a problem hiding this comment.
Thnx for working on this. I would love to discuss what is precisely happening in this added code. But I am off-course 100% ok with this addition. Looking at the tests though, it is not clear what is being tested here. I am looking for a test that shows that the POST method is working.
| @@ -103,6 +103,8 @@ export default class ResultsViewPage extends React.Component< | |||
|
|
|||
| handleLegacySubmission(this.urlWrapper); | |||
|
|
|||
| handlePostedSubmission(this.urlWrapper); | |||
There was a problem hiding this comment.
So if I understand this correctly, only the ResultsViewPage can handle POST requests?
There was a problem hiding this comment.
that's correct. the server writes the post data in all cases though so any page can in theory access it.
|
|
||
| if (useExternalFrontend) { | ||
|
|
||
| describe('error messaging for invalid study id(s)', function(){ |
There was a problem hiding this comment.
I am lost here. This file resutspage.spec.js has describe study select page which belongs to Query Page. So, what does this test actually test? Is there also a test that checks for correct working of the POST method? It is not apparent from the test titles. It seems to only deal with checking of error messages.
There was a problem hiding this comment.
achhh. terrible, i forgot to update these descriptions. they are totally wrong.
There was a problem hiding this comment.
i will make PR to correct these.
| "genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION":"coadread_tcga_pub_gistic" | ||
| }; | ||
|
|
||
| postDataToUrl(url, query); |
There was a problem hiding this comment.
data is posted to page here
| var url = browser.getUrl(); | ||
|
|
||
| // make sure param in query is passed to url | ||
| return _.every(query,(item,key)=>{ |
There was a problem hiding this comment.
@pvannierop here we check that every posted parameter key has made it into the url. this could only happen as a result of our code transferring the postData variable into the URL.
External applications may send users to portal using http post (for large queries). JSP writes this posted data to postData variable. Frontend needs to consume this data.