Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated failing study view screenshots #3049

Merged
merged 1 commit into from Feb 10, 2020
Merged

Updated failing study view screenshots #3049

merged 1 commit into from Feb 10, 2020

Conversation

ecerami
Copy link
Contributor

@ecerami ecerami commented Feb 9, 2020 •
edited

Fixes cBioPortal/cbioportal#7135

Describe changes proposed in this pull request:

  • updated screenshot 1 from circle ci: end-to-end-test/remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png
  • updated screenshot 2 from circle ci: end-to-end-test/remote/screenshots/reference/when_quickly_adding_charts,_each_chart_should_get_proper_data._element_chrome_1600x1000.png

You can see how these tests previously failed via: https://61737-66571349-gh.circle-artifacts.com/0/imageCompare.html

Checks

  • Looks like end-to-end tests are now passing, but end-to-end local tests are still failing (due to another issue that I can log).

Any screenshots or GIFs?

Yes, see above

Notify reviewers

@inodb

@ecerami ecerami requested a review from inodb February 10, 2020 10:53
@inodb inodb merged commit 5bec674 into cBioPortal:master Feb 10, 2020
@inodb inodb added the test label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
2 participants
@ecerami @inodb