-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make study view dropdown not refresh unnecessarily when removing a chart #3132
make study view dropdown not refresh unnecessarily when removing a chart #3132
Conversation
adamabeshouse
commented
Apr 2, 2020
1a343ff
to
d609d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. but looks like circleCI is failing
848e601
to
646f3c0
Compare
@adamabeshouse we still have situation on first load where we show options before frequency has loaded. they are not in appropriate sorting order because it depends on frequency. we need to ask product team whether this is desirable or whether we should just wait until frequency is loaded to show anything (@jjgao). The only reason I can think to show unsorted is because frequency sometimes takes a long time and a user might want to just click something instead of waiting for frequency. Also, When we click between tabs inside of the charts dropdown, even once all data is loaded, there is still a loader the flashes. Can we investigate why? |
646f3c0
to
baa7947
Compare
@adamabeshouse i think there's a broken e2e on this one: Also, if it's not too much trouble could you center the loading animation and text beneath it? also maybe push it down 100px. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about centering animation/message
@adamabeshouse also, make sure to rebase because @kalletlak made a fix (just merted) that might possible overlap with yours. i don't think so, but possible. |
387e7b6
to
fb0be2c
Compare
…arily when chart removed Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
(1) hide options until frequencies are done loading (2) dont unmount on hide so that the frequencies are cached and we dont have reloading Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
fb0be2c
to
f50d847
Compare
make study view dropdown not refresh unnecessarily when removing a chart Former-commit-id: 63a28b5