Study View: Restrict api calls if there are no valid studies in query #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What UI shows up in this case? Do we have any idea how these invalid study ids came about? |
|
It might be unauthorized studies. I don't have access to this study.
|
alisman
reviewed
Apr 13, 2020
| @@ -386,7 +386,9 @@ export default class StudyViewPage extends React.Component< | |||
| {this.store.queriedSampleIdentifiers.isComplete && | |||
| this.store.invalidSampleIds.isComplete && | |||
| this.store.unknownQueriedIds.isComplete && | |||
| this.store.displayedStudies.isComplete && ( | |||
| this.store.displayedStudies.isComplete && | |||
| this.store.queriedPhysicalStudies.isComplete && | |||
There was a problem hiding this comment.
i'm curious to know why this wouldn't be caught by unknownQueriedIds (above). Maybe the study list service returns the ID even if user doesn't have access to it?
|
I think this is ok. Would sort of be nice to have more explicit validation routine so that reader can understand exactly what needs to be true for studies to be valid. |
alisman
approved these changes
Apr 13, 2020
inodb
pushed a commit
to inodb/cbioportal-frontend
that referenced
this pull request
Jan 12, 2022
Study View: Restrict api calls if there are no valid studies in query Former-commit-id: 49b8957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#7381