Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect script reference in the module publish action #3149

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

onursumer
Copy link
Member

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
@onursumer onursumer requested a review from inodb April 14, 2020 21:19
@onursumer onursumer merged commit f8cef4b into cBioPortal:master Apr 14, 2020
@onursumer onursumer deleted the fix-module-publish-workflow branch April 14, 2020 22:01
@onursumer onursumer added the cl-bug Bug section of changelog. Bug fix label Apr 14, 2020
inodb pushed a commit to inodb/cbioportal-frontend that referenced this pull request Jan 12, 2022
…workflow

Fix incorrect script reference in the module publish action

Former-commit-id: f8cef4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-bug Bug section of changelog. Bug fix
Projects
None yet
2 participants