Dont include CNA gain or hetloss when querying DRIVER in OQL #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
oql-driver
branch
from
1abcbb3
to
6947a62
Compare
inodb
approved these changes
Apr 16, 2020
inodb
reviewed
Apr 16, 2020
| @@ -1,21 +1,111 @@ | |||
| /* eslint camelcase: "off" */ | |||
There was a problem hiding this comment.
@adamabeshouse what's the main change here - adding types (js -> ts)? Anything else?
There was a problem hiding this comment.
that plus just the logic change I just indicated below
inodb
reviewed
Apr 16, 2020
| @@ -1,83 +0,0 @@ | |||
| //export function filterCBioPortalWebServiceData(oql_query, data, opt_default_oql, opt_by_oql_line, opt_mark_oql_regulation_direction) { | |||
There was a problem hiding this comment.
@adamabeshouse why can this be removed now?
There was a problem hiding this comment.
we no longer need a type declaration file because the actual file is now in typescript. before, this served as like a typescript interface.
adamabeshouse
commented
Apr 16, 2020
| ); | ||
| const cnaValue = accessors.cna(datum); | ||
| datumWanted = | ||
| cnaValue !== 'gain' && // dont include gains or hetloss here |
There was a problem hiding this comment.
only logic change is here @inodb
adamabeshouse
force-pushed
the
oql-driver
branch
from
6947a62
to
55e7571
Compare
alisman
reviewed
Apr 16, 2020
| private isMutation(d: Datum): d is Mutation { | ||
| return ( | ||
| this.molecularAlterationType(d.molecularProfileId) === | ||
| 'MUTATION_EXTENDED' |
There was a problem hiding this comment.
Don't we have this in enum somewhere?
There was a problem hiding this comment.
yes, good catch, I was just copy pasting code here
alisman
approved these changes
Apr 16, 2020
adamabeshouse
force-pushed
the
oql-driver
branch
from
55e7571
to
56ea272
Compare
added 2 commits
April 16, 2020 14:04
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
oql-driver
branch
from
56ea272
to
443048d
Compare
jjgao
reviewed
Apr 17, 2020
inodb
pushed a commit
to inodb/cbioportal-frontend
that referenced
this pull request
Jan 12, 2022
Dont include CNA gain or hetloss when querying DRIVER in OQL Former-commit-id: e74b99a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#7376
When querying
EGFR: DRIVERFrom:
to: